Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AssemblyProcessor] Fixed packing path. #1987

Merged
merged 1 commit into from Oct 25, 2023
Merged

Conversation

Basewq
Copy link
Contributor

@Basewq Basewq commented Oct 25, 2023

PR Details

Description

Directory specified went a level up too far so nothing gets packed/copied to the deps folder.

Related Issue

Issue caused by #1894

Motivation and Context

AssemblyProcessor project does not complete its build properly due to incorrect path for dll copying and IL packing.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@manio143 manio143 merged commit 861eea6 into stride3d:master Oct 25, 2023
1 check passed
@manio143
Copy link
Member

The build in TeamCity is green again, thanks!

@Basewq Basewq deleted the asm_fix branch October 28, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants