[Build] Fix native library loading picking up invalid files

[Basewq]

PR Details

Description

NuGet importer allows 'non-native' files in LockFileTargetLibrary.NativeLibraries, however as per research #1750 (comment) this leads to a subtle incorrect dll loading if multiple files with the same file name exists (eg. freetype.dll & freetype.pdb).
Wasn't sure whether a blacklist, whitelist or some priority sort would be preferred to ensure the correct file get loaded. I've settled on a small blacklist set but I'm open to change it to a different way.
EDIT: Changed to allowlist logic.

Related Issue

Fixes #1750

Motivation and Context

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My change requires a change to the documentation.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have built and run the editor to try this change out.

[manio143]

If these are native libs we expect to collect here I think an allowlist for dll, so, dylib and any other lib extension would be better to avoid having to amend this list much in the future if other files are accidentally included.

[Basewq]

If these are native libs we expect to collect here I think an allowlist for dll, so, dylib and any other lib extension would be better to avoid having to amend this list much in the future if other files are accidentally included.

Fair enough. Are you aware of any other extensions?
According to this https://learn.microsoft.com/en-us/dotnet/standard/native-interop/native-library-loading
it seems like there's only those three, but looks like we will also need to include .Contains(".so.") for linux files.
Unfortunately, I'm not knowledgeable on about non-Windows platforms so not sure what file types they use.

[manio143]

As far as I could see iOS and MacOS use dylib and Android and Linux use so. At the moment this should be enough.