Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenVR] Handle custom resolution specified by the user through VR settings #2000

Merged
merged 1 commit into from Oct 31, 2023
Merged

[OpenVR] Handle custom resolution specified by the user through VR settings #2000

merged 1 commit into from Oct 31, 2023

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Oct 29, 2023

PR Details

I.e.: support this slider and update at runtime
image

Related Issue

None reported

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

manio143
manio143 approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@manio143 manio143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tebjan tebjan self-requested a review October 30, 2023 17:41
@Eideren Eideren merged commit edb2618 into stride3d:master Oct 31, 2023
11 of 14 checks passed
@Eideren Eideren deleted the vr_custom_res branch October 31, 2023 19:48
@tebjan tebjan mentioned this pull request Feb 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tebjan tebjan tebjan approved these changes

@manio143 manio143 manio143 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Eideren @tebjan @manio143