Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback changes to Stride.Native.targets and add StrideNative.cpp #2047

Merged
merged 1 commit into from Nov 18, 2023
Merged

Rollback changes to Stride.Native.targets and add StrideNative.cpp #2047

merged 1 commit into from Nov 18, 2023

Conversation

Kryptos-FR
Copy link
Member

This ensures libstride is built.

PR Details

Without that, neither libstrideaudio nor libstridenavigation were built.

Description

Related PR

#1926

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR
Rollback changes to Stride.Native.targets and add StrideNative.cpp to…
23c5f1a 
… ensure libstride is built.

Without that, neither libstrideaudio nor libstridenavigation were built.
@manio143 manio143 merged commit f01db83 into stride3d:master Nov 18, 2023
1 check passed
@Kryptos-FR Kryptos-FR deleted the feature/native-fix branch November 18, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kryptos-FR @manio143