Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Repair Projectwatcher on Projects referencing each other #2288

Merged
merged 4 commits into from
May 29, 2024

Conversation

IXLLEGACYIXL
Copy link
Collaborator

PR Details

The Issue was if you have the Projects

...\\...\\FancyGame\\FancyGame.csproj
...\\...\\FancyGame.Test\\FancyGame.Test.csproj

Then the first one to compare the starts with path is always the root project of the game

now if you change the file ...\\...\\FancyGame.Test\\Bob.cs the path comparison starts with the first project and a normal StartsWith , which results in true the directory path of the file ...\\...\\FancyGame.Test starts with the root projects directory path ...\\...\\FancyGame so the root project gets reloaded as lowest level of the dependencies of the solution.. but that isnt true FancyGame.Test is lower and has the file but it isnt even checked as the first trigger yields

Related Issue

fix #2200

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

Copy link
Collaborator

@Eideren Eideren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a bunch @IXLLEGACYIXL

@Eideren Eideren merged commit 3f0c3ce into stride3d:master May 29, 2024
13 checks passed
@Eideren
Copy link
Collaborator

Eideren commented May 29, 2024

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Projects require Module class if they reference eachother.
3 participants