[WIP] Update SharpDX dependency to version 4.2.0 #277
Conversation
|
|
xen2
changed the title
|
Thanks! Added WIP in title to reflect current state. |
|
@Venthe do you need a specific feature of sharpdx 4.2 or do you know if a bug of the current version that influences xenko? if you update to 4.2 it is forcing all other projects that work with xenko to update as well. i would appreciate to not have to do that just now. current version is well tested and works at the momemt and i don't know the implications of the upgrade and whether it causes problems or new bugs... EDIT: @Venthe didn't want to sound negative towards the pull request, glad to see other devs enjoyng the engine. it was just critical thinking. if you have a tested update, go ahead. if it doesn't work on our end we can downgrade. |
|
@tebjan no, it's okay. I had a spare time; so I'll probably confirm it's working state & will wait for the new version for the merge |
|
@tebjan Would it be OK to upgrade now for 3.1? Or you think better to keep version as low as possible? |
|
if the upgrade doesn't break anything, i think it's safe to go for it. it might well be the last SharpDX version since alexandre droppend support for it. so everyone will end up at this version sooner or later. for us it would be a bit more easy to stay on the current version since we have third party dependencies that also use that one. but i can do a PR there as well to move up to 4.2. so go ahead, we will manage... |
|
It looks as if SharpDX has been updated to 4.2.0. @xen2 should this PR request be closed? |
|
Yes, thanks ! |
Update to latest SharpDX #34
It is not yet tested., give me a few days. Pull request made to signal that someone is working :)