[Localization] Fix build for path containing spaces

[Kryptos-FR]

PR Details

If the path to the project contains any spaces, then the build steps for the localization files will fail.

Description

Escape all paths in the command line. Special case for$(TargetDir) that needs an extra . since otherwise the last quote is escaped as well.

Related Issue

None.

Motivation and Context

Building from sources will fail for users that have a space in the path where the sources are located. Especially annoying if the space is in the username.

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My change requires a change to the documentation.
• I have added tests to cover my changes.
• All new and existing tests passed.

[dfkeenan]

You should probably also update "\docs\technical\editor-localization.md".

[xen2]

Curious, shouldn't it be " rather than "?

Also, note that if I create a new csproj, it uses <Target Name="PreBuild" BeforeTargets="PreBuildEvent"> rather than PostBuildEvent. Xml values vs attribute might have different escape rules (esp. attribute you can use single quote as main delimiter so that double quote works as is).

[dfkeenan]

According to the XML spec " is only required for attribute values.

[xen2]

@dfkeenan ok thanks for the clarification (not a XML expert).

I will probably merge this PR as is then.

[dfkeenan]

I'm no expert either. But I did some googling and everything I found only mentioned " in regards to attributes.

There were already " in there just not on all file paths. And seeing how it builds (I assume) I don't think it will make things worse. :)

[xen2]

Thanks, merged!