Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Physics] Restore mesh implementation state from PR #289 #479

Closed
wants to merge 1 commit into from

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Jun 27, 2019

PR Details

As mentioned on PR #289 this PR only addresses creating static mesh colliders from mesh assets, static mesh colliders can already be created from vertex positions + triangle indices.

Related Issue

None.

Motivation and Context

See PR #289.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Notes

Here are some of the issues blocking further development:

  • Mesh data is uploaded to the GPU as soon as it is deserialized, we don't store it in CPU mem.
  • Deserialization happens in bulk, we can't just read mesh data from disk. We need to somehow wait for the mesh's buffers to be initialized and retrieve the data used to create those.
  • Master cannot yet easily extract mesh data at runtime from the GPU, see reading buffers without command list

@Eideren
Copy link
Collaborator Author

Eideren commented Apr 9, 2022

This is superseded by #1251 which has been merged in master, closing this one.

@Eideren Eideren closed this Apr 9, 2022
@Eideren Eideren deleted the physics_static_mesh branch September 30, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant