Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hotness queries and materializer (#25) #127

Merged
merged 4 commits into from
Aug 20, 2023
Merged

Conversation

itstolf
Copy link
Collaborator

@itstolf itstolf commented Aug 14, 2023

also reformatted some sql

@vercel
Copy link

vercel bot commented Aug 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bsky-furry-feed-admin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2023 6:38pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
bsky-furry-feed-info ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2023 6:38pm

@itstolf itstolf force-pushed the itstolf/hot-mess branch 2 times, most recently from 08b1d7c to 62dc1dc Compare August 14, 2023 19:31
@itstolf itstolf force-pushed the itstolf/hot-mess branch 2 times, most recently from 40a6f88 to 2dd6967 Compare August 14, 2023 19:33
@itstolf itstolf marked this pull request as ready for review August 15, 2023 07:52
@itstolf itstolf changed the title add hotness queries and scaffolding for materializer (#25) add hotness queries and materializer (#25) Aug 15, 2023
Copy link
Owner

@strideynet strideynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this strategy looks good - but I do wonder if scoring the posts in Go rather than SQL might give us more flexibility in adding new Algos - but I can equally see this sucking from a perf aspect. My gut feeling is to run with what you've done here and we can always move it to Go in future if we want to.

cmd/bffsrv/main.go Outdated Show resolved Hide resolved
store/queries/post_hotness.sql Outdated Show resolved Hide resolved
store/queries/post_hotness.sql Outdated Show resolved Hide resolved
store/queries/post_hotness.sql Outdated Show resolved Hide resolved
feed/feed.go Outdated Show resolved Hide resolved
feed/feed.go Outdated Show resolved Hide resolved
feed/feed.go Show resolved Hide resolved
store/queries/post_hotness.sql Outdated Show resolved Hide resolved
store/migrations/000017_create_post_hotness.up.sql Outdated Show resolved Hide resolved
@strideynet strideynet merged commit b907833 into main Aug 20, 2023
6 of 7 checks passed
@strideynet strideynet deleted the itstolf/hot-mess branch August 20, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants