Fix #11: Factor out StorageChecker #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of this refactoring is merely to decouple StorageChecker from StaticQuotaCallback, to facilitate better unit-cases Signed-off-by: kwall <kwall@apache.org>
…val is a value in seconds. Signed-off-by: kwall <kwall@apache.org>
|
Tested locally within Kafka. Verified that existing behaviour retained. |
tombentley
approved these changes
Feb 28, 2022
|
Thanks for the PR. |
SamBarker
pushed a commit
to SamBarker/kafka-quotas-plugin
that referenced
this pull request
Sep 5, 2022
* Fix strimzi#11: Factor out StorageChecker The intent of this refactoring is merely to decouple StorageChecker from StaticQuotaCallback, to facilitate better unit-cases Signed-off-by: kwall <kwall@apache.org> * Document the existing behaviour that the plugin accepts a check-interval is a value in seconds. Signed-off-by: kwall <kwall@apache.org> (cherry picked from commit 3c968a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this refactoring is merely to decouple StorageChecker from StaticQuotaCallback, to facilitate better unit-cases.
Signed-off-by: kwall kwall@apache.org