Add metrics note #44
Merged
Add metrics note #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
scholzj
reviewed
Mar 13, 2024
There was a problem hiding this comment.
If you think this helps, I'm happy to approve and merge it.
But to be honest, I'm not convinced users will understand what it really means. From the issue I assumed that you would add something like ...
Kafka let's you use only one quotas plugin. So if you enable this quotas plugin, the quotas built-in Apache Kafka will stop working and will not produce any metrics.
What you add sounds like the quotas will work but only some metrics will not be produced? That seems weird.
Should it also add some names of the metrics? That might also help to understand what exactly it is talking about.
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
What about this modified version? |
scholzj
approved these changes
Mar 13, 2024
It's already updated. |
ppatierno
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #32.