feat: propose proposal template #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a template for future Strimzi proposals, based on existing proposals Signed-off-by: Matthew Chirgwin <chirmatt@uk.ibm.com>
samuel-hawker
approved these changes
Jul 8, 2020
scholzj
reviewed
Jul 8, 2020
There was a problem hiding this comment.
My view ...
- I'm probably missing some _Current situation section to describe the current state as a starting point.
- I think also explicit section about Backwards compatibility might be useful as a reminder.
- On the other hand I think the split of the Proposal section goes maybe a bit too deep. I would probably remove the subchapters.
Overall - as mentioned by Sam - I would make it clear this is optional and I don't have a big issue with this.
ppatierno
approved these changes
Jul 9, 2020
- Add sections for compatibility and the current situation - Add a comment to the proposal mentioning this is for example purposes and that it can be followed/modified to best suit the proposal being made Signed-off-by: Matthew Chirgwin <chirmatt@uk.ibm.com>
|
Hi All, thank you for the comments. I have just updated the PR to reflect them. |
scholzj
approved these changes
Jul 9, 2020
|
@Frawless @tombentley any comments on this? |
samuel-hawker
approved these changes
Jul 24, 2020
Frawless
approved these changes
Jul 24, 2020
tombentley
approved these changes
Jul 30, 2020
|
Thanks for the PR @matthew-chirgwin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposals
Signed-off-by: Matthew Chirgwin chirmatt@uk.ibm.com