Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to change canary logging verbosity and enable/disable Sarama logger at runtime #166

Closed
ppatierno opened this issue Jan 27, 2022 · 0 comments
Closed

Allow to change canary logging verbosity and enable/disable Sarama logger at runtime #166

ppatierno opened this issue Jan 27, 2022 · 0 comments
Milestone
0.3.0

Comments

@ppatierno
Copy link
Member

Currently it's possible to specify the logging verbosity of the canary itself and enabling/disabling the Sarama logger via environment variables.
When an error occurs in a canary instance running, it would be great to increase/enable both at runtime without restarting the canary (because the issue could disappear).
One way could be having an "optional" configuration file for the canary (specifying its path via an env var?) where configuration parameters could be specified and overriding what's defined via env vars.
The canary could then have a periodic internal service watching changes to this file and change internal config accordingly.
@ppatierno ppatierno mentioned this issue Jan 27, 2022
Open
@k-wall k-wall mentioned this issue Feb 1, 2022
Closed
k-wall added a commit to k-wall/strimzi-canary that referenced this issue Feb 3, 2022
@k-wall
Fix strimzi#166: support the dynamic modification of logging levels
31b209a
k-wall added a commit to k-wall/strimzi-canary that referenced this issue Feb 3, 2022
@k-wall
Fix strimzi#166: support the dynamic modification of logging levels
c9a9072 
Signed-off-by: kwall <kwall@apache.org>
k-wall added a commit to k-wall/strimzi-canary that referenced this issue Feb 4, 2022
@k-wall
Fix strimzi#166: support the dynamic modification of logging levels
ee72672 
Signed-off-by: kwall <kwall@apache.org>
k-wall added a commit to k-wall/strimzi-canary that referenced this issue Feb 4, 2022
@k-wall
Fix strimzi#166: support the dynamic modification of logging levels
a98f55c 
Signed-off-by: kwall <kwall@apache.org>
k-wall added a commit to k-wall/strimzi-canary that referenced this issue Feb 6, 2022
@k-wall
Fix strimzi#166: support the dynamic modification of logging levels
8059cf2 
Signed-off-by: kwall <kwall@apache.org>
@scholzj scholzj closed this as completed in 4bc73ed Feb 8, 2022
k-wall added a commit to k-wall/strimzi-canary that referenced this issue Feb 9, 2022
@k-wall
Fix data race issue introduced by strimzi#166
3d349e9 
(reported by go test --race ./...)

Signed-off-by: kwall <kwall@apache.org>
@k-wall k-wall mentioned this issue Feb 9, 2022
Merged
scholzj pushed a commit that referenced this issue Feb 9, 2022
@k-wall
Fix data race issue introduced by #166 (#169)
2838af4 
* Fix data race issue introduced by #166

(reported by go test --race ./...)

Signed-off-by: kwall <kwall@apache.org>

* Avoid mutation of sarama.Logger by go routines without mutex

(Logger.SetOutput protects by mutex so is safe)

Signed-off-by: kwall <kwall@apache.org>

* organise for goroutine within watcher to complete

Signed-off-by: kwall <kwall@apache.org>
@ppatierno ppatierno added this to the 0.3.0 milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
1 participant
@ppatierno