Add oauth metrics into the jmx_metrics_config.yaml
#718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
scholzj
reviewed
Nov 28, 2022
|
@scholzj good question, I will try it |
|
@scholzj I tested this with just enabled metrics, without Oauth, and it just prints metrics, that are available. There are no Oauth metrics at all (there is no NaN or nulls etc.) |
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
ppatierno
approved these changes
Nov 28, 2022
|
Those metrics, which I'm adding to the Bridge, I found in Oauth repository from @mstruk , so I assumed that's all needed. |
scholzj
approved these changes
Nov 28, 2022
|
Sorry for late chiming-in. It looks good yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lukas Kral lukywill16@gmail.com
In Oauth 0.11.0, the oauth metrics were introduced.
But, to scrape these Oauth metrics from Bridge, we need to add the correct patterns into the
jmx_metrics_config.yaml.This PR does it.