Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JBOD storage version validation in KRaft #10017

Merged

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Apr 23, 2024

Type of change

  • Bugfix

Description

This PR improves the Kafka version validation when JBOD storage is used in KRaft:

  • It validates the from version instead of the to version to better handle upgrades (not allow JBOD storage before the upgrade to 3.7.0 is done)
  • Checks that the metadata version is set to 3.7

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.41.0 milestone Apr 23, 2024
@scholzj scholzj requested a review from ppatierno April 23, 2024 16:10
@scholzj
Copy link
Member Author

scholzj commented Apr 23, 2024

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj closed this Apr 23, 2024
@scholzj scholzj deleted the imrove-JBOD-storage-version-validation branch April 23, 2024 19:20
@scholzj scholzj restored the imrove-JBOD-storage-version-validation branch April 23, 2024 20:46
@scholzj scholzj reopened this Apr 23, 2024
@ppatierno
Copy link
Member

/azp run migration

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assuming even migration pipeline is green.

@scholzj scholzj merged commit 03c5572 into strimzi:main Apr 24, 2024
25 checks passed
@scholzj scholzj deleted the imrove-JBOD-storage-version-validation branch April 24, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants