Remove unneeded state (old certificate secrets) from the Ca classes
#10023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Apr 26, 2024
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/CruiseControl.java
Show resolved
Hide resolved
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The
Caclasses currently hold the old certificate secrets as a state through the whole reconciliation. This increases memory consumption but could be also misleading as they might not be up to date and might contain old certificates.They seem to be used only in two places. One right after the state is set and one later in the reconciliation where we anyway query the secret again. So it seems to be easy to remove it and pass them to the methods directly as done in this PR.
This should also make it easier to split the one big Secret with all Kafka node certificates
Checklist