Rebuild the Kafka Connect image only when the rebuild annotation is set to true #10030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et to true Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
Apr 27, 2024
ppatierno
approved these changes
Apr 28, 2024
scholzj
deleted the
rebuild-connect-image-only-when-the-annotation-is-set-to-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Rebuild of the Kafka Connect image (when using the Kafka Connect Build feature) can be triggered using the
strimzi.io/force-rebuildannotation. But right now, we only check if this annotation is present and not its value. So we trigger the rebuild even when the annotation is for example set tofalse. This PR fixes it and checks the actual value of the annotation and does the rebuild only when it is set totrue.Checklist