Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system test] - KRaft JBOD test cases #10035

Merged
merged 8 commits into from
May 2, 2024
Merged

[system test] - KRaft JBOD test cases #10035

merged 8 commits into from
May 2, 2024

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Apr 29, 2024 •
edited

Type of change

  • Enhancement / new feature

Description

This PR adds more coverage on the KRaft JBOD storage part. It adds two test cases:

  1. testResizeJbodVolumes
  2. testJbodMetadataLogRelocation

Both cases are described in the PR code so take a look at that if you are interested.
TLDR; Both test cases use a client to prove that during re-sizing JBOD or relocation of the KRaft metadata log, there are no missing messages.

Checklist

  • Write tests
  • Make sure all tests pass

@see-quick see-quick requested review from scholzj and a team April 29, 2024 11:56
@see-quick see-quick self-assigned this Apr 29, 2024
@see-quick see-quick added this to the 0.41.0 milestone Apr 29, 2024
im-konge
im-konge reviewed Apr 29, 2024
View reviewed changes
.../src/main/java/io/strimzi/systemtest/utils/kubeUtils/objects/PersistentVolumeClaimUtils.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/KafkaST.java Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/KafkaST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/KafkaST.java Show resolved Hide resolved
...emtest/src/test/java/io/strimzi/systemtest/rollingupdate/AlternativeReconcileTriggersST.java Outdated Show resolved Hide resolved
...emtest/src/test/java/io/strimzi/systemtest/rollingupdate/AlternativeReconcileTriggersST.java Outdated Show resolved Hide resolved
...emtest/src/test/java/io/strimzi/systemtest/rollingupdate/AlternativeReconcileTriggersST.java Show resolved Hide resolved
...emtest/src/test/java/io/strimzi/systemtest/rollingupdate/AlternativeReconcileTriggersST.java Outdated Show resolved Hide resolved
...emtest/src/test/java/io/strimzi/systemtest/rollingupdate/AlternativeReconcileTriggersST.java Outdated Show resolved Hide resolved
...emtest/src/test/java/io/strimzi/systemtest/rollingupdate/AlternativeReconcileTriggersST.java Outdated Show resolved Hide resolved
ppatierno
ppatierno approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question but LGTM overall.

systemtest/src/test/java/io/strimzi/systemtest/kafka/KafkaST.java
* - persistent-volume-claims
*/
@ParallelNamespaceTest
void testResizeJbodVolumes() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if this addition should deserve its own PR because no KRaft related, or?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep it in this PR, if that works for everyone.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah let's keep it here

scholzj
scholzj approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming the tests pass). Should be reviewed by an ST SME.

im-konge
im-konge approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@see-quick
Copy link
Member Author

/azp list

@see-quick
Copy link
Member Author

/azp run regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick
Copy link
Member Author

/azp run kraft-regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick
Copy link
Member Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.15 --install-type=bundle --profile=all -testcase=KafkaST#testResizeJbodVolumes

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@see-quick
Copy link
Member Author

/azp run regression

@see-quick
Copy link
Member Author

/azp run kraft-regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strimzi-ci
Copy link

❗ Systemtests Failed (no tests results are present) ❗

@see-quick
[system test] - add more JBOD related test cases
0fa5f73 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
[system test] KRaft JBOD test cases
d773417 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
just one nit
62751b6 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
another one
c82d7e8 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
Lukas comments
d7a8bce 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
update also test
c145e0e 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
update to remove dynamic
f7a7ad0 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
update conditionals
fcb4703 
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
Copy link
Member Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.15 --install-type=bundle --profile=all -testcase=KafkaST#testResizeJbodVolumes

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

❌ Test Summary ❌

TEST_PROFILE: all
GROUPS:
TEST_CASE:
TOTAL: 107
PASS: 103
FAIL: 3
SKIP: 1
BUILD_NUMBER: 74
OCP_VERSION: 4.15
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

❗ Test Failures ❗

  • testCustomCertRouteAndTlsRollingUpdate in io.strimzi.systemtest.kafka.listeners.ListenersST
  • testKafkaAndKafkaConnectTlsVersion in io.strimzi.systemtest.security.SecurityST

Re-run command:
@strimzi-ci run tests --profile=all --testcase=io.strimzi.systemtest.kafka.listeners.ListenersST#testCustomCertRouteAndTlsRollingUpdate,io.strimzi.systemtest.security.SecurityST#testKafkaAndKafkaConnectTlsVersion

@see-quick
Copy link
Member Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.15 --install-type=bundle --profile=all --testcase=KafkaST#testResizeJbodVolumes

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS:
TEST_CASE: KafkaST#testResizeJbodVolumes
TOTAL: 1
PASS: 1
FAIL: 0
SKIP: 0
BUILD_NUMBER: 75
OCP_VERSION: 4.15
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

@see-quick
Copy link
Member Author

/azp run regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick see-quick added the ready for merge Label for PRs which are ready for merge label May 2, 2024
@see-quick
Copy link
Member Author

/azp run feature-gates-regression

@see-quick see-quick removed the ready for merge Label for PRs which are ready for merge label May 2, 2024
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick see-quick added the ready for merge Label for PRs which are ready for merge label May 2, 2024
@see-quick see-quick merged commit a962aa2 into strimzi:main May 2, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im-konge im-konge im-konge approved these changes

@scholzj scholzj scholzj approved these changes

@ppatierno ppatierno ppatierno approved these changes

Assignees

@see-quick see-quick

Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Milestone
0.41.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@see-quick @strimzi-ci @scholzj @ppatierno @im-konge