Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance] Re-name perf test suites to not include in UTs #10043

Merged
merged 4 commits into from
May 1, 2024

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Apr 30, 2024

Type of change

  • Bugfix
  • Enhancement / new feature

Description

This PR fixes a problem when we trigger a Jenkins with mvn verify -pl systemtest -P all it goes through two stages:

  1. test = where it currently also runs performance tests because they have a suffix which ends with Test
  2. integration test = and then our STs...

Removing this suffix solves such a problem and we should only run them via specific profiles (i.e., performance or performance-capacity).

Checklist

  • Make sure all tests pass

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
Copy link
Member Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.15 --install-type=bundle --profile=acceptance

@see-quick see-quick added this to the 0.41.0 milestone Apr 30, 2024
@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

Signed-off-by: see-quick <maros.orsak159@gmail.com>
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit. Thanks :)

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: acceptance
GROUPS:
TEST_CASE:
TOTAL: 32
PASS: 32
FAIL: 0
SKIP: 0
BUILD_NUMBER: 72
OCP_VERSION: 4.15
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
Copy link
Member Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.15 --install-type=bundle --profile=performance

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: performance
GROUPS:
TEST_CASE:
TOTAL: 33
PASS: 33
FAIL: 0
SKIP: 0
BUILD_NUMBER: 73
OCP_VERSION: 4.15
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

@see-quick see-quick added ready for merge Label for PRs which are ready for merge and removed needs review labels May 1, 2024
@see-quick see-quick merged commit f6349d2 into strimzi:main May 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance ready for merge Label for PRs which are ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants