Improve broken ZooKeeperScaler tests #10046
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR improves two ZooKeeper Scaler tests that are a little bit broken. The tests do not fail, but do not test what they should anymore as the expected exceptions are not thrown as part of the tests. In one case, proper certificates need to be supplied in order to get the desired error from the client and test how it is closed. In the other, the exception needs to be properly instantiated.
Checklist