Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] MigrationST - add checks for JBOD storage, change the main tests to be parametrized #10057

Merged
merged 3 commits into from
May 6, 2024

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented May 3, 2024

Type of change

  • Enhancement

Description

This PR adds test checks (and tests) for migration/rollback with Kafka containing JBOD storage (in both broker and controller).
Together with this I did a small refactor of the ST class and changed the two main tests (for migration and rollback) to be parametrized tests. That's because there are more parameters + it will be clear which test cases we cover (because we had there one redundant test, so this should make it more clear).

Finally, this PR changes the test documentation to reflect the changes.

Closes #10000

Checklist

  • Write tests
  • Make sure all tests pass

…s, remove redundant test, change test documentation

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge requested a review from ppatierno May 3, 2024 15:12
@im-konge im-konge added this to the 0.41.0 milestone May 3, 2024
@im-konge im-konge self-assigned this May 3, 2024
@im-konge im-konge requested a review from a team May 3, 2024 15:12
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge
Copy link
Member Author

im-konge commented May 3, 2024

/azp run migration

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a one nit to consider ... Thanks 👍

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left just a comment.

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge
Copy link
Member Author

im-konge commented May 6, 2024

/azp run migration

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge im-konge merged commit 6942a2a into strimzi:main May 6, 2024
15 checks passed
@im-konge im-konge deleted the migration-jbod branch May 6, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ST] Add migration system tests with JBOD support in KRaft mode
3 participants