-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ST] MigrationST - add checks for JBOD storage, change the main tests to be parametrized #10057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, remove redundant test, change test documentation Signed-off-by: Lukas Kral <lukywill16@gmail.com>
/azp run migration |
Azure Pipelines successfully started running 1 pipeline(s). |
see-quick
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a one nit to consider ... Thanks 👍
systemtest/src/test/java/io/strimzi/systemtest/migration/MigrationST.java
Show resolved
Hide resolved
ppatierno
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left just a comment.
systemtest/src/test/java/io/strimzi/systemtest/migration/MigrationST.java
Show resolved
Hide resolved
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
/azp run migration |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR adds test checks (and tests) for migration/rollback with Kafka containing JBOD storage (in both broker and controller).
Together with this I did a small refactor of the ST class and changed the two main tests (for migration and rollback) to be parametrized tests. That's because there are more parameters + it will be clear which test cases we cover (because we had there one redundant test, so this should make it more clear).
Finally, this PR changes the test documentation to reflect the changes.
Closes #10000
Checklist