Fix /controller znode failure handling during KRaft migration rollback
#10058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run migration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
reviewed
May 3, 2024
...perator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KRaftMigrationUtils.java
Outdated
Show resolved
Hide resolved
...perator/src/main/java/io/strimzi/operator/cluster/operator/assembly/KRaftMigrationUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Signed-off-by: Paolo Patierno <ppatierno@live.com>
Signed-off-by: Paolo Patierno <ppatierno@live.com>
ppatierno
force-pushed
the
fix-delete-controller-znode-failure
branch
from
5045055
to
6adafb8
Compare
|
/azp run migration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
approved these changes
May 6, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR adds the handling of failures, if any, when the operator deletes the
/controllerznode during a KRaft migration rollback. The current code, just log a warning and continue which is not right. This PR adds correct handling with failed Future to fail the reconciliation.There are a lot of file changes on several tests classes, because I had to add a way to mock the ZooKeeper admin provider through the resource supplier.
Checklist
Please go through this checklist and make sure all applicable tasks have been done