Move dependency analysis from the root pom.xml to the modules #10062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strimzi#8572 Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run kraft-regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
May 6, 2024
scholzj
deleted the
move-dependency-analysis-from-project-parent-to-the-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR moves the Mavane dependency analysis from the root
pom.xmlfile to the modules. This allows us to have more granular controller over the dependencies that are ignored unused etc. as we now configure them on the module level and not once for the whole project.As part of this PR, I also fixed some smaller test issues I discovered thanks to this:
CronTestwas for some reason testing the Log4j cron expression instead of the Quartz onekafka-agenttests were not exected at all because they were written for JUnit 4 and not JUnit 5This PR should resolve #8572
Checklist