Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning when kraftMetadata is used in storage configuration for ZooKeeper-based clusters #10067

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented May 6, 2024

Type of change

  • Enhancement / new feature

Description

This PR adds a warning when the kraftMetadata option in the storage configuration is used in ZooKeeper-based cluster.

To simplify the code, the warning message is generic without mentioning the exact resource(s) (Kafka or KafkaNodePool) where the issue is. Creating the warning including such a detailed message would significantly increase the complexity as it would require several things:

  • Information about the KRaft state (enabled, disabled, etc.)
  • Detailed information about the original resources configuration
  • The warnings to be passed to the custom resource status

These three are not available in one place and the effort to bring them together does not seem to be worth the effort.

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

… ZooKeeper-based clusters

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 0.41.0 milestone May 6, 2024
@scholzj scholzj requested a review from ppatierno May 6, 2024 15:40
@scholzj
Copy link
Member Author

scholzj commented May 6, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj
Copy link
Member Author

scholzj commented May 6, 2024

/azp run kraft-regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks and sorry for bothering you with this request ;-)

@scholzj scholzj merged commit 4bdde66 into strimzi:main May 7, 2024
29 checks passed
@scholzj scholzj deleted the add-warning-when-KRaft-Metadata-volume-is-configured-in-ZooKeeper-mode branch May 7, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants