Fix model warnings

[fvaleri]

The additional properties is made consistent with lazy initialization across all model classes. There also few similar changes.

[ppatierno]

I left a couple of comments but I was wondering if we should do something like we already have with the abstract Spec class which is already defining the additional properties this way and then it's inherited by all the XXXXSpec classes.
Here, we are duplicating the same code across the model classes to do the same thing, maybe a similar abstract class would simplify the code avoiding duplication.

[fvaleri]

I was wondering if we should do something like we already have with the abstract Spec class which is already defining the additional properties this way and then it's inherited by all the XXXXSpec classes.

Good idea. We already have UnknownPropertyPreserving interface, so we could add default implementations there. Would that work?

[scholzj]

I was wondering if we should do something like we already have with the abstract Spec class which is already defining the additional properties this way and then it's inherited by all the XXXXSpec classes.

Good idea. We already have UnknownPropertyPreserving interface, so we could add default implementations there. Would that work?

Some of the ways in the API are weird in how the various tools handle it. I'm not sure you can use default methods for it and for additional properties it is hard to test.

[fvaleri]

Some of the ways in the API are weird in how the various tools handle it. I'm not sure you can use default methods for it and for additional properties it is hard to test.

Yeah, let me double check this. Thanks.

[fvaleri]

@ppatierno I tried with both default methods and abstract class. The former approach compiles but then you have hundreds of test failures, the latter doesn't work in our case as you can only extend one class.

[scholzj]

Few more nits. But LGTM otherwise. Let's see if all the changed configs really work - I will run the STs.

[scholzj]

/azp run regression

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ppatierno]

LGTM. Nothing more from me. Let's see if tests pass.