Docs: Try to improve the docs about custom CAs #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppatierno
approved these changes
Feb 8, 2019
documentation/book/proc-installing-your-own-ca-certificates.adoc
Outdated
Show resolved
Hide resolved
ncbaratta
approved these changes
Feb 8, 2019
documentation/book/proc-installing-your-own-ca-certificates.adoc
Outdated
Show resolved
Hide resolved
documentation/book/proc-installing-your-own-ca-certificates.adoc
Outdated
Show resolved
Hide resolved
Co-Authored-By: scholzj <www@scholzj.com>
Co-Authored-By: scholzj <www@scholzj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
After some experience with multiple users try to get custom CAs working, I prepared an minor update to the relevant section of the documentation which important things which are missing or not obvious:
kubectl labelandoc labelcommands to separate step. Many users including me missed them because they were hidden at the end of a very long command. This should hopefully make it a bit more noticeableFurther feedback would be welcome.
Checklist