Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Upgrade for 0.12 #1659

Merged
merged 4 commits into from
Jun 3, 2019
Merged

[DOC] Upgrade for 0.12 #1659

merged 4 commits into from
Jun 3, 2019

Conversation

PaulRMellor
Copy link
Contributor

Type of change

  • Documentation

Description

Updates to the Upgrade chapter
Following consultation, the x to y Cluster Operator upgrade procedures have been replaced with a generic cluster operator upgrade procedure. The generic procedure now includes a link to the resource updates chapter in the final step.

Additionally, the attributes used in the Kafka upgrade procedures -- lower and higher Kafka version and log version -- have been updated to 2.1.1 and 2.2.0 and 2.1 and 2.2 respectively.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Update/write design documentation in ./design
  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

Copy link
Member

@tombentley tombentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@d-laing d-laing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one comment.

@PaulRMellor
Copy link
Contributor Author

@scholzj - are we ready to merge?

@scholzj
Copy link
Member

scholzj commented May 31, 2019

No, I haven't reviewed it yet.

@scholzj
Copy link
Member

scholzj commented May 31, 2019 via email

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good. My main concern is that this does not make it clear that it talks about the upgrade from 0.11.x to 0.12.x. We should make it more clear that for any older version upgrades the users should look up the older docs.

@scholzj scholzj merged commit 2dda0d1 into strimzi:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants