Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Authorization doc super users #1774

Merged
merged 11 commits into from
Jul 5, 2019
Merged

[DOC] Authorization doc super users #1774

merged 11 commits into from
Jul 5, 2019

Conversation

d-laing
Copy link
Member

@d-laing d-laing commented Jul 4, 2019

Type of change

  • Documentation

Description

This pull request adds information on designating super users to the Authorization section. It provides documentation for issue #1121 .

I also made a few edits to the existing content, e.g. defining ACLs.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Update/write design documentation in ./design
  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

documentation/book/proc-kafka-authorization.adoc Outdated Show resolved Hide resolved
documentation/book/ref-kafka-authorization.adoc Outdated Show resolved Hide resolved
documentation/book/ref-kafka-authorization.adoc Outdated Show resolved Hide resolved
documentation/book/ref-kafka-authorization.adoc Outdated Show resolved Hide resolved
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more to add than the comments from Jakub. I approve in relation to those change requests.

Daniel Laing and others added 5 commits July 5, 2019 09:35
Suggested change

Co-Authored-By: Jakub Scholz <www@scholzj.com>
Suggested change

Co-Authored-By: Jakub Scholz <www@scholzj.com>
Suggested change

Co-Authored-By: Jakub Scholz <www@scholzj.com>
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments. I also have a pending task to expand on the use of SimpleAclAuthorizer.

Daniel Laing and others added 4 commits July 5, 2019 10:36
Suggested change

Co-Authored-By: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com>
Suggested change

Co-Authored-By: Jakub Scholz <www@scholzj.com>
@scholzj scholzj merged commit 48fa6e1 into strimzi:master Jul 5, 2019
@d-laing d-laing changed the title Authorization doc super users [DOC] Authorization doc super users Jul 8, 2019
@d-laing d-laing deleted the authorization-doc-super-users branch July 8, 2019 08:30
`SimpleAclAuthorizer` is the default authorization plugin which is part of Apache Kafka.
To enable simple authorization, the `type` field should be set to `simple`.
Simple authorization in {ProductName} uses the `SimpleAclAuthorizer` plugin, the default Access Control Lists (ACLs) authorization plugin provided with Apache Kafka. ACLs allow you to define which users have access to which resources at a granular level.
To enable simple authorization, set the `type` field to `simple`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laidan6000 should this instance of simple be capitalized?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. What do you think, Paolo? @ppatierno

@scholzj scholzj added this to the 0.13.0 milestone Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants