[DOC] Document Forced CA Cert Renewal and Key Replacement #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholzj
reviewed
Jul 15, 2019
PaulRMellor
reviewed
Jul 16, 2019
PaulRMellor
reviewed
Jul 16, 2019
PaulRMellor
reviewed
Jul 16, 2019
PaulRMellor
reviewed
Jul 16, 2019
Co-Authored-By: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com>
Co-Authored-By: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com>
|
@scholzj - the procedures are now updated with changes from your review. Please check again, thanks. |
scholzj
reviewed
Jul 17, 2019
There was a problem hiding this comment.
Few more comments. But looks good otherwise. Thanks.
@ppatierno Do you think you could have a look at this as well?
ppatierno
reviewed
Jul 18, 2019
Co-Authored-By: Jakub Scholz <www@scholzj.com>
|
Great feedback, thank you. @scholzj and @ppatierno - please check and approve. I reworded the final part of both procedures to start with the case where maintenance time windows are not configured. It's then easier to explain what happens if they are configured. I removed maintenance time windows from the prerequisites. |
ppatierno
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This pull request adds new procedures for:
It documents the annotations
strimzi.io/force-renewandstrimzi.io/force-replace, which were originally added in #1193 (see the discussion in the comments between @tombentley and @ppatierno for context).Checklist
Please go through this checklist and make sure all applicable tasks have been done
./design