New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ST: add new test tags and fix test #1961
Conversation
@strimzi-ci run tests test_only profile=regression |
❌ Test Summary ❌TEST_PROFILE: regression ❗ Test Failures ❗
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit & a question, otherwise LGTM.
bb0498a
to
5855b2a
Compare
Signed-off-by: Jakub Stejskal <stejskinek@gmail.com>
Signed-off-by: Jakub Stejskal <stejskinek@gmail.com>
5855b2a
to
d333c99
Compare
Signed-off-by: Jakub Stejskal <stejskinek@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a nit comment.
// Apply updated env variables | ||
clusterOperator.getSpec().getTemplate().getSpec().getContainers().get(0).setEnv(envVars); | ||
|
||
return new DeploymentBuilder(clusterOperator) | ||
.withApiVersion("apps/v1") | ||
// .withApiVersion("apps/v1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove line or comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
Signed-off-by: Jakub Stejskal <stejskinek@gmail.com>
Signed-off-by: Jakub Stejskal <stejskinek@gmail.com>
Signed-off-by: Jakub Stejskal stejskinek@gmail.com
Type of change
Description
This PR includes several changes:
STRIMZI_OPERATION_TIMEOUT_MS
variableNew tags will allow us to skip specific tags during test execution on specific environments.
Checklist