Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ST: add new test tags and fix test #1961

Merged
merged 5 commits into from Sep 7, 2019
Merged

Conversation

Frawless
Copy link
Member

@Frawless Frawless commented Sep 5, 2019

Signed-off-by: Jakub Stejskal stejskinek@gmail.com

Type of change

  • Bugfix
  • Refactoring

Description

This PR includes several changes:

  • Fix for redeploy environment after failure, where CO was deployed with default value for STRIMZI_OPERATION_TIMEOUT_MS variable
  • Add option to specify image pull policy for kafka cluster components via env variable
  • Add new tags for nodeport, loadbalancer and networkpolicies. Reason for this is caused by different environment which we can currently used and not all of them support all features.

New tags will allow us to skip specific tags during test execution on specific environments.

Checklist

  • Make sure all tests pass

@Frawless Frawless added this to the 0.14.0 milestone Sep 5, 2019
@Frawless
Copy link
Member Author

Frawless commented Sep 5, 2019

@strimzi-ci run tests test_only profile=regression

@strimzi-ci
Copy link

❌ Test Summary ❌

TEST_PROFILE: regression
TEST_CASE: *ST
TOTAL: 125
PASS: 106
FAIL: 18
SKIP: 1

❗ Test Failures ❗

  • testForUpdateValuesInConnectCM in io.strimzi.systemtest.ConnectST
  • testJvmAndResources in io.strimzi.systemtest.ConnectST
  • testKafkaConnectWithFileSinkPlugin in io.strimzi.systemtest.ConnectST
  • testSecretsWithKafkaConnectWithTlsAuthentication in io.strimzi.systemtest.ConnectST
  • testEODeletion in io.strimzi.systemtest.KafkaST
  • testKafkaJBODDeleteClaimsTrue in io.strimzi.systemtest.KafkaST
  • io.strimzi.systemtest.metrics.MetricsST in io.strimzi.systemtest.metrics.MetricsST
  • testDeployMirrorMakerAcrossMultipleNamespace in io.strimzi.systemtest.AllNamespaceST
  • testDeployMirrorMakerAcrossMultipleNamespace in io.strimzi.systemtest.MultipleNamespaceST
  • testDeployS2IWithMongoDBPlugin in io.strimzi.systemtest.ConnectS2IST
  • testRecoveryDuringZookeeperRollingUpdate in io.strimzi.systemtest.RollingUpdateST
  • testRecoveryDuringKafkaRollingUpdate in io.strimzi.systemtest.RollingUpdateST
  • testMirrorMakerTlsScramSha in io.strimzi.systemtest.MirrorMakerST
  • testNetworkPoliciesWithTlsListener in io.strimzi.systemtest.SecurityST
  • testCertRegeneratedAfterInternalCAisDeleted in io.strimzi.systemtest.SecurityST
  • testNetworkPoliciesWithPlainListener in io.strimzi.systemtest.SecurityST
  • testMoreReplicasThanAvailableBrokers in io.strimzi.systemtest.TopicST
  • testUserWithNameMoreThan64Chars in io.strimzi.systemtest.UserST

Copy link
Member

@tombentley tombentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit & a question, otherwise LGTM.

systemtest/pom.xml Outdated Show resolved Hide resolved
Signed-off-by: Jakub Stejskal <stejskinek@gmail.com>
Signed-off-by: Jakub Stejskal <stejskinek@gmail.com>
Signed-off-by: Jakub Stejskal <stejskinek@gmail.com>
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a nit comment.

// Apply updated env variables
clusterOperator.getSpec().getTemplate().getSpec().getContainers().get(0).setEnv(envVars);

return new DeploymentBuilder(clusterOperator)
.withApiVersion("apps/v1")
// .withApiVersion("apps/v1")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove line or comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Signed-off-by: Jakub Stejskal <stejskinek@gmail.com>
@Frawless Frawless added ready for merge Label for PRs which are ready for merge System tests labels Sep 7, 2019
Signed-off-by: Jakub Stejskal <stejskinek@gmail.com>
@scholzj scholzj merged commit a712805 into strimzi:master Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants