Kube-side changes to #replicas should result in NotReady status #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholzj
approved these changes
Sep 11, 2019
There was a problem hiding this comment.
LGTM. But it should be reviewed also by @ppatierno who knows TO much better. What is the relation of this to #1950? Does it superseed it? Should we close it?
Its supercedes it. I'll close that one once this one has been merged. |
This changes the Topic Operator's handling of Kube-side changes to KafkaTopic.spec.replicas by ensuring the reconciliation results in a NotReady status. If the replication factor is changed on the Kafka side then the reconciliation updates KafkaTopic.spec.replicas and results in Ready status. Note that, because the TO doesn't watch the relevent ZK nodes, the KafkaTopic.spec.replicas only gets updated during a periodic reconciliation. An integration test is added for the revised semantics. Because change in replicas has never been supported I have also removed unused the code which notionally allowed for the TO to perform partition reassignment, but in fact was never used. Fix strimzi#1847, fix strimzi#691 Signed-off-by: Tom Bentley <tbentley@redhat.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This changes the Topic Operator's handling of Kube-side changes to
KafkaTopic.spec.replicas by ensuring the reconciliation results in a
NotReady status. If the replication factor is changed on the Kafka side
then the reconciliation updates KafkaTopic.spec.replicas and results in
Ready status.
Note that, because the TO doesn't watch the relevent ZK nodes, the
KafkaTopic.spec.replicas only gets updated during a periodic reconciliation.
An integration test is added for the revised semantics.
Because change in replicas has never been supported I have also removed
unused the code which notionally allowed for the TO to perform partition
reassignment, but in fact was never used.
Fix #1847, fix #691