Use requests instead of limits for determining Xmx #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How have you tested this? |
sknot-rh
force-pushed
the
use-requests-instead-limits
branch
from
183deb4
to
c39e40d
Compare
scholzj
requested changes
Nov 25, 2019
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/AbstractModel.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/AbstractModel.java
Outdated
Show resolved
Hide resolved
cluster-operator/src/main/java/io/strimzi/operator/cluster/model/AbstractModel.java
Outdated
Show resolved
Hide resolved
sknot-rh
force-pushed
the
use-requests-instead-limits
branch
2 times, most recently
from
41bd2a4
to
a79bc5c
Compare
scholzj
approved these changes
Nov 25, 2019
tombentley
approved these changes
Nov 25, 2019
ppatierno
approved these changes
Nov 25, 2019
|
@stanlyDoge Could you add this to the CHANGELOG and make it clear what exactly changed and how does it impact the users?? |
Signed-off-by: Stanislav Knot <sknot@redhat.com>
sknot-rh
force-pushed
the
use-requests-instead-limits
branch
from
955668a
to
cfc2244
Compare
sknot-rh
force-pushed
the
use-requests-instead-limits
branch
from
cfc2244
to
2176513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stanislav Knot sknot@redhat.com
Type of change
Description
Fixes #2203
It was not clear for me, how the setting of
ENV_VAR_DYNAMIC_HEAP_MAXworked with the user's value. Please take a look and feel free to describe how it should work.Checklist
./design