Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Remove backup command from CO upgrade procedure #2766

Merged
merged 1 commit into from
Apr 1, 2020
Merged

[DOC] Remove backup command from CO upgrade procedure #2766

merged 1 commit into from
Apr 1, 2020

Conversation

d-laing
Copy link
Member

@d-laing d-laing commented Mar 31, 2020

Signed-off-by: Daniel Laing dlaing@redhat.com

Type of change

  • Documentation

Description

Edits the procedure for Upgrading the Cluster Operator.

Step one contains a command for backing up your existing Cluster Operator resources before starting the upgrade:

kubectl get all -l app=strimzi -o yaml > strimzi-backup.yaml

This command is misleading: it doesn't work everywhere because of missing labels, it doesn't back up everything, and doesn't make it any easier to extract the changes pre-upgrade. Therefore, I've replaced this with a general step advising users to take note of any configuration changes made to their existing CO resources.

I've also made some other changes to improve the readability of the procedure.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Update/write design documentation in ./design
  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging // NO RELEVANT ISSUES FOUND
  • Update CHANGELOG.md

Signed-off-by: Daniel Laing <dlaing@redhat.com>
@d-laing d-laing changed the title [DOC] Remove backup command from CO upgrade procedure, plus readability edits [DOC] Remove backup command from CO upgrade procedure Mar 31, 2020
@d-laing d-laing added this to the 0.18.0 milestone Mar 31, 2020
@strimzi-ci
Copy link

Can one of the admins verify this patch?
Run tests: @strimzi-ci run tests

Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@d-laing d-laing added ready for merge Label for PRs which are ready for merge and removed ready for merge Label for PRs which are ready for merge labels Apr 1, 2020
@scholzj scholzj merged commit 7a54c1c into strimzi:master Apr 1, 2020
javiercri pushed a commit to javiercri/strimzi-kafka-operator that referenced this pull request Oct 11, 2020
Signed-off-by: Daniel Laing <dlaing@redhat.com>
Signed-off-by: Javier Criado <javier.criado@MAC00083.home>
klalafaryan pushed a commit to klalafaryan/strimzi-kafka-operator that referenced this pull request Oct 21, 2020
Signed-off-by: Daniel Laing <dlaing@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation peer-review-done ready for merge Label for PRs which are ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants