Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[systemtest] Fix tests failing on ocp4.x #3528

Merged
merged 2 commits into from
Aug 20, 2020
Merged

[systemtest] Fix tests failing on ocp4.x #3528

merged 2 commits into from
Aug 20, 2020

Conversation

im-konge
Copy link
Member

Signed-off-by: Lukas Kral lukywill16@gmail.com

Type of change

  • Bugfix

Description

This PR fixes testDeployKafkaClusterViaTemplate where the client.customResourceDefinitions().list().getItems() throws exception about k8s list. It seems like there is some problem with Fabric8 version (this will be hopefully fixed by @stanlyDoge). So I made a small workaround to get number of CRDs that contains label app=strimzi -> for this I needed the exact number of CRDs that we are applying -> so for this I created the getCrdsCount() method.

The testDeployKafkaClusterViaTemplate affected these two tests: testLabelsAndAnnotationForPVC and testEODeletion.

Checklist

  • Make sure all tests pass

@im-konge im-konge self-assigned this Aug 19, 2020
@im-konge im-konge added this to the 0.20.0 milestone Aug 19, 2020
@im-konge
Copy link
Member Author

@strimzi-ci run tests crc test_only profile=regression testcase=KafkaST,MetricsST

samuel-hawker
samuel-hawker approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@samuel-hawker samuel-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strimzi-ci
Copy link

❌ Test Summary ❌

TEST_PROFILE: regression
EXCLUDED_GROUPS: ,flaky
TEST_CASE: KafkaST,MetricsST
TOTAL: 4
PASS: 0
FAIL: 4
SKIP: 0
BUILD_NUMBER: 1396
BUILD_ENV: crc

❗ Test Failures ❗

  • testKafkaBridgeMetrics in io.strimzi.systemtest.metrics.MetricsST
  • testDynamicConfigurationWithExternalListeners in io.strimzi.systemtest.kafka.KafkaST
  • testDynamicConfigurationExternalTls in io.strimzi.systemtest.kafka.KafkaST

Re-run command:
@strimzi-ci run tests true profile=regression testcase=io.strimzi.systemtest.metrics.MetricsST#testKafkaBridgeMetrics,io.strimzi.systemtest.kafka.KafkaST#testDynamicConfigurationWithExternalListeners,io.strimzi.systemtest.kafka.KafkaST#testRegenerateCertExternalAddressChange,io.strimzi.systemtest.kafka.KafkaST#testDynamicConfigurationExternalTls

@im-konge
Copy link
Member Author

The testKafkaBridgeMetrics will be fixed by #3200

It seems that failing only tests with external listeners and I think that these tests will always fail on crc. So I guess that everything is fixed.

@im-konge
Copy link
Member Author

@strimzi-ci run tests test_only profile=regression testcase=KafkaST

@scholzj
Copy link
Member

scholzj commented Aug 20, 2020

It seems that failing only tests with external listeners and I think that these tests will always fail on crc. So I guess that everything is fixed.

So should these tests be not run based on some flag or something?

@im-konge
Copy link
Member Author

@scholzj it fails only on tests where is used loadbalancer as "external listener" -> I'll add it to excluded groups for CRC. I have PR about jenkins, so I'm gonna add it there

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: regression
EXCLUDED_GROUPS: networkpolicies,flaky
TEST_CASE: KafkaST
TOTAL: 27
PASS: 27
FAIL: 0
SKIP: 0
BUILD_NUMBER: 1400
BUILD_ENV: oc cluster up

@im-konge
fixes
b0c882a 
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge
comment
11053ff 
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@scholzj scholzj merged commit ee12d9b into strimzi:master Aug 20, 2020
@im-konge im-konge deleted the nightlies branch August 24, 2020 06:19
klalafaryan pushed a commit to klalafaryan/strimzi-kafka-operator that referenced this pull request Oct 21, 2020
@im-konge @klalafaryan
[systemtest] Fix tests failing on ocp4.x (strimzi#3528)
4db605c 
* fixes

Signed-off-by: Lukas Kral <lukywill16@gmail.com>

* comment

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@ppatierno ppatierno ppatierno approved these changes

@Frawless Frawless Frawless approved these changes

@samuel-hawker samuel-hawker samuel-hawker approved these changes

@tombentley tombentley Awaiting requested review from tombentley

Assignees

@im-konge im-konge

Labels
bug needs review System tests
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@im-konge @strimzi-ci @scholzj @tombentley @ppatierno @Frawless @samuel-hawker