Do not use ownerReference for EO role in separate watched namespace #4588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frawless
approved these changes
Mar 17, 2021
ppatierno
approved these changes
Mar 17, 2021
scholzj
deleted the
fix-role-owner-reference-in-separate-watched-namespace
branch
scholzj
added a commit
that referenced
this pull request
Mar 17, 2021
…4588) Signed-off-by: Jakub Scholz <www@scholzj.com>
AaruniAggarwal
pushed a commit
to AaruniAggarwal/strimzi-kafka-operator
that referenced
this pull request
Mar 18, 2021
…trimzi#4588) Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
When user configures TO or UO to watch a different namespace, a role needs to be created there. And it has to be created without the owner reference - otherwise would Kubernetes immediately garbage collect it and the TO/UO will not work.
This PR should be cheery-picked to 0.22.x branch and used for 0.22.1 patch release.
Checklist