New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Use PKCS12 files directly when configuring client access from outside Kubernetes #4924
Merged
scholzj
merged 2 commits into
strimzi:main
from
d-laing:docs-feedback-external-client-access-truststore-keystore
May 12, 2021
Merged
[DOC] Use PKCS12 files directly when configuring client access from outside Kubernetes #4924
scholzj
merged 2 commits into
strimzi:main
from
d-laing:docs-feedback-external-client-access-truststore-keystore
May 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Laing <dlaing@redhat.com>
Can one of the admins verify this patch? |
scholzj
approved these changes
May 7, 2021
PaulRMellor
reviewed
May 10, 2021
documentation/modules/deploying/proc-deploy-setup-external-clients.adoc
Outdated
Show resolved
Hide resolved
PaulRMellor
reviewed
May 10, 2021
documentation/modules/deploying/proc-deploy-setup-external-clients.adoc
Outdated
Show resolved
Hide resolved
PaulRMellor
approved these changes
May 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Couple of comments around PEM format, which a note in the intro to the procedure might resolve
Signed-off-by: Daniel Laing <dlaing@redhat.com>
Good point about the certificate formats. I changed the intro as suggested. |
ppatierno
approved these changes
May 12, 2021
d-laing
added
ready for merge
Label for PRs which are ready for merge
peer-review-done
sme-review-done
and removed
peer-review-needed
sme-review-needed
labels
May 12, 2021
scholzj
pushed a commit
that referenced
this pull request
May 12, 2021
…utside Kubernetes (#4924) * edit procedure Signed-off-by: Daniel Laing <dlaing@redhat.com> * review comment PM Signed-off-by: Daniel Laing <dlaing@redhat.com>
d-laing
deleted the
docs-feedback-external-client-access-truststore-keystore
branch
May 13, 2021 12:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Laing dlaing@redhat.com
Type of change
Description
Guide(s) updated: Deploying and Upgrading Strimzi
Content: Setting up access for clients outside of Kubernetes
This pull request separates the steps for extracting the certificate and password from the public cluster CA certificate and user certificate. It also updates the sample code.
Checklist