Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Use PKCS12 files directly when configuring client access from outside Kubernetes #4924

Merged
merged 2 commits into from May 12, 2021
Merged

[DOC] Use PKCS12 files directly when configuring client access from outside Kubernetes #4924

merged 2 commits into from May 12, 2021

Conversation

d-laing
Copy link
Member

@d-laing d-laing commented May 7, 2021

Signed-off-by: Daniel Laing dlaing@redhat.com

Type of change

  • Documentation

Description

Guide(s) updated: Deploying and Upgrading Strimzi
Content: Setting up access for clients outside of Kubernetes

This pull request separates the steps for extracting the certificate and password from the public cluster CA certificate and user certificate. It also updates the sample code.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Signed-off-by: Daniel Laing <dlaing@redhat.com>
@strimzi-ci
Copy link

Can one of the admins verify this patch?

@d-laing d-laing requested a review from PaulRMellor May 10, 2021 10:42
Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple of comments around PEM format, which a note in the intro to the procedure might resolve

@scholzj scholzj added this to the 0.24.0 milestone May 10, 2021
Signed-off-by: Daniel Laing <dlaing@redhat.com>
@d-laing
Copy link
Member Author

d-laing commented May 11, 2021

Good point about the certificate formats. I changed the intro as suggested.

@scholzj scholzj merged commit b015826 into strimzi:main May 12, 2021
@scholzj scholzj modified the milestones: 0.24.0, 0.23.0 May 12, 2021
scholzj pushed a commit that referenced this pull request May 12, 2021
…utside Kubernetes (#4924)

* edit procedure

Signed-off-by: Daniel Laing <dlaing@redhat.com>

* review comment PM

Signed-off-by: Daniel Laing <dlaing@redhat.com>
@d-laing d-laing deleted the docs-feedback-external-client-access-truststore-keystore branch May 13, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation peer-review-done ready for merge Label for PRs which are ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants