-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Procedure to load external configuration values #5139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: prmellor <pmellor@redhat.com>
Can one of the admins verify this patch? |
PaulRMellor
commented
Jun 16, 2021
documentation/modules/configuring/proc-loading-config-with-provider.adoc
Outdated
Show resolved
Hide resolved
scholzj
reviewed
Jun 16, 2021
api/src/main/java/io/strimzi/api/kafka/model/connect/ExternalConfiguration.java
Outdated
Show resolved
Hide resolved
api/src/main/java/io/strimzi/api/kafka/model/connect/ExternalConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: prmellor <pmellor@redhat.com>
Signed-off-by: prmellor <pmellor@redhat.com>
Signed-off-by: prmellor <pmellor@redhat.com>
scholzj
approved these changes
Jun 16, 2021
tombentley
approved these changes
Jun 16, 2021
documentation/modules/configuring/proc-loading-config-with-provider.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: prmellor <pmellor@redhat.com>
LiamClarkeNZ
pushed a commit
to LiamClarkeNZ/strimzi-kafka-operator
that referenced
this pull request
Jun 21, 2021
* [DOC] Procedure to load external configuration values Signed-off-by: prmellor <pmellor@redhat.com> * review edits JS Signed-off-by: prmellor <pmellor@redhat.com> * Decsription edit PM Signed-off-by: prmellor <pmellor@redhat.com> * Decsription edit PM Signed-off-by: prmellor <pmellor@redhat.com> * review edits TB Signed-off-by: prmellor <pmellor@redhat.com> Signed-off-by: Liam Clarke-Hutchinson <lclarkeh@redhat.com>
LiamClarkeNZ
pushed a commit
to LiamClarkeNZ/strimzi-kafka-operator
that referenced
this pull request
Jun 21, 2021
* [DOC] Procedure to load external configuration values Signed-off-by: prmellor <pmellor@redhat.com> * review edits JS Signed-off-by: prmellor <pmellor@redhat.com> * Decsription edit PM Signed-off-by: prmellor <pmellor@redhat.com> * Decsription edit PM Signed-off-by: prmellor <pmellor@redhat.com> * review edits TB Signed-off-by: prmellor <pmellor@redhat.com> Signed-off-by: Liam Clarke-Hutchinson <lclarkeh@redhat.com>
LiamClarkeNZ
pushed a commit
to LiamClarkeNZ/strimzi-kafka-operator
that referenced
this pull request
Jun 22, 2021
* [DOC] Procedure to load external configuration values Signed-off-by: prmellor <pmellor@redhat.com> * review edits JS Signed-off-by: prmellor <pmellor@redhat.com> * Decsription edit PM Signed-off-by: prmellor <pmellor@redhat.com> * Decsription edit PM Signed-off-by: prmellor <pmellor@redhat.com> * review edits TB Signed-off-by: prmellor <pmellor@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: prmellor pmellor@redhat.com
Documentation
Adds a new procedure to the Configuring a Strimzi deployment section in the Using Strimzi guide.
Loading configuration values from external sources describes how to use the Kubernetes Configuration Provider to load external configuration values.
There are also links to the procedure from the Kafka Connect and MirrorMaker configuration sections.
Plus: minor change to a property description in the schema reference.
Checklist
Please go through this checklist and make sure all applicable tasks have been done