Fix config diff test #5530
Merged
Fix config diff test #5530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stanislav Knot <sknot@redhat.com>
tombentley
reviewed
Sep 6, 2021
Comment on lines
275
to
+277
| ces.add(new ConfigEntry("inter.broker.listener.name", "david")); | ||
| ces.add(new ConfigEntry("group.min.session.timeout.ms", "42")); | ||
| ces.add(new ConfigEntry("host.name", "honza")); | ||
| ces.add(new ConfigEntry("zookeeper.sync.time.ms", "8000")); |
There was a problem hiding this comment.
Can we add comments for why we chose these three configs specifically?
There was a problem hiding this comment.
There is no specific reason. We are doing just 3 random changes. Property host.name was removed from kafka 3.0.0 config model, so we just switched to another property.
There was a problem hiding this comment.
Might be still worth a comment that they are randomly chosen without any deeper meaning ... even that is an information which might be useful.
...est/java/io/strimzi/operator/cluster/operator/resource/KafkaBrokerConfigurationDiffTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stanislav Knot <sknot@redhat.com>
scholzj
reviewed
Sep 6, 2021
tombentley
approved these changes
Sep 6, 2021
scholzj
reviewed
Sep 6, 2021
...est/java/io/strimzi/operator/cluster/operator/resource/KafkaBrokerConfigurationDiffTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stanislav Knot <sknot@redhat.com>
scholzj
approved these changes
Sep 6, 2021
scholzj
pushed a commit
to scholzj/strimzi-kafka-operator
that referenced
this pull request
Sep 20, 2021
* Fix KafkaBrokerConfigurationDiffTest Signed-off-by: Stanislav Knot <sknot@redhat.com> * review comments Signed-off-by: Stanislav Knot <sknot@redhat.com> * reenable Signed-off-by: Stanislav Knot <sknot@redhat.com> * review comments Signed-off-by: Stanislav Knot <sknot@redhat.com>
scholzj
pushed a commit
that referenced
this pull request
Sep 23, 2021
* Fix KafkaBrokerConfigurationDiffTest Signed-off-by: Stanislav Knot <sknot@redhat.com> * review comments Signed-off-by: Stanislav Knot <sknot@redhat.com> * reenable Signed-off-by: Stanislav Knot <sknot@redhat.com> * review comments Signed-off-by: Stanislav Knot <sknot@redhat.com>
scholzj
added a commit
that referenced
this pull request
Sep 24, 2021
* Add support for Kafka 3.0.0 Signed-off-by: Jakub Scholz <www@scholzj.com> * [Kafka 3.x] Remove deprecated methods from TO (#5522) Signed-off-by: Stanislav Knot <sknot@redhat.com> * Rebase & Disable failing unit tests Signed-off-by: Jakub Scholz <www@scholzj.com> * Fix one more test Signed-off-by: Jakub Scholz <www@scholzj.com> * Fix mocking (#5527) Signed-off-by: Stanislav Knot <sknot@redhat.com> * Fix TO ITs Signed-off-by: Jakub Scholz <www@scholzj.com> * Fix config diff test (#5530) * Fix KafkaBrokerConfigurationDiffTest Signed-off-by: Stanislav Knot <sknot@redhat.com> * review comments Signed-off-by: Stanislav Knot <sknot@redhat.com> * reenable Signed-off-by: Stanislav Knot <sknot@redhat.com> * review comments Signed-off-by: Stanislav Knot <sknot@redhat.com> * Close the EmbeddedKafkaClusters Signed-off-by: Jakub Scholz <www@scholzj.com> * Fix TO build Signed-off-by: Jakub Scholz <www@scholzj.com> * Update to 3.0.0 RC2 Signed-off-by: Jakub Scholz <www@scholzj.com> * Add Kafka 2.8.1 as well Signed-off-by: Jakub Scholz <www@scholzj.com> * Update to final version of 3.0.0 Signed-off-by: Jakub Scholz <www@scholzj.com> * Fix TopicST and update upgrade STs JSON Signed-off-by: Jakub Scholz <www@scholzj.com> * check if supported kafka versions contains version (#5606) Signed-off-by: Lukas Kral <lukywill16@gmail.com> * Review comments JSt Signed-off-by: Jakub Scholz <www@scholzj.com> Co-authored-by: Stanislav Knot <sknot@redhat.com> Co-authored-by: Lukáš Král <53821852+im-konge@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Use reflection to call package-protected ctor to fix tests.
Checklist