Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kafka exporter dependency #5575

Merged
merged 3 commits into from Sep 22, 2021
Merged

Conversation

sknot-rh
Copy link
Member

Signed-off-by: Stanislav Knot sknot@redhat.com

Type of change

  • Bugfix
  • Enhancement

Description

We used custom forked version as the original repo did not seem to be updated for a while. Since then the repo has become active again and all the fixes from our custom versions are present upstream. There is a new release containing all the fixes.
Fixes #5529

Logging on trace level

I0917 07:21:34.387290      11 kafka_exporter.go:769] Starting kafka_exporter (version=1.4.2, branch=HEAD, revision=0d5d4ac4ba63948748cc2c53b35ed95c310cd6f2)
I0917 07:21:34.387393      11 kafka_exporter.go:770] Build context (go=go1.17.1, user=root@d6c4c344dbf3, date=20210916-09:43:31)
I0917 07:21:35.446482      11 kafka_exporter.go:254] Done Init Clients
I0917 07:21:35.446626      11 kafka_exporter.go:929] Listening on HTTP :9404
I0917 07:22:01.387501      11 kafka_exporter.go:320] concurrent calls detected, waiting for first to finish
I0917 07:22:01.387637      11 kafka_exporter.go:366] Refreshing client metadata
I0917 07:22:01.565897      11 kafka_exporter.go:637] Fetching consumer group metrics
I0917 07:22:31.387117      11 kafka_exporter.go:320] concurrent calls detected, waiting for first to finish

Logging on info level

I0917 07:20:27.670678      10 kafka_exporter.go:769] Starting kafka_exporter (version=1.4.2, branch=HEAD, revision=0d5d4ac4ba63948748cc2c53b35ed95c310cd6f2)
I0917 07:20:28.758943      10 kafka_exporter.go:929] Listening on HTTP :9404

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Signed-off-by: Stanislav Knot <sknot@redhat.com>
@sknot-rh sknot-rh added this to the 0.26.0 milestone Sep 17, 2021
@sknot-rh sknot-rh requested a review from a team September 17, 2021 07:28
Signed-off-by: Stanislav Knot <sknot@redhat.com>
@scholzj
Copy link
Member

scholzj commented Sep 21, 2021

Do we need to fix the docs somehow? For example https://strimzi.io/docs/operators/latest/full/using.html#type-KafkaExporterSpec-reference?

@scholzj
Copy link
Member

scholzj commented Sep 22, 2021

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Stanislav Knot <sknot@redhat.com>
@sknot-rh sknot-rh requested a review from alesj September 22, 2021 08:03
@scholzj scholzj merged commit c6413fb into strimzi:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Kafka Exporter] Changing log level does not seem to work
3 participants