Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated Fabric8 method createOrReplace from the project #8310

Merged
merged 7 commits into from Apr 5, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -35,7 +35,7 @@ public KafkaBridge get(String namespace, String name) {
}
@Override
public void create(KafkaBridge resource) {
kafkaBridgeClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
kafkaBridgeClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).create();
}
@Override
public void delete(KafkaBridge resource) {
Expand Down
Expand Up @@ -26,7 +26,7 @@ public Deployment get(String namespace, String name) {

@Override
public void create(Deployment resource) {
ResourceManager.kubeClient().namespace(resource.getMetadata().getNamespace()).createOrReplaceDeployment(resource);
ResourceManager.kubeClient().namespace(resource.getMetadata().getNamespace()).createDeployment(resource);
}
@Override
public void delete(Deployment resource) {
Expand Down
Expand Up @@ -35,7 +35,7 @@ public KafkaConnect get(String namespace, String name) {
}
@Override
public void create(KafkaConnect resource) {
kafkaConnectClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
kafkaConnectClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).create();
}
@Override
public void delete(KafkaConnect resource) {
Expand Down
Expand Up @@ -31,7 +31,7 @@ public KafkaConnector get(String namespace, String name) {

@Override
public void create(KafkaConnector resource) {
kafkaConnectorClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
kafkaConnectorClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).create();
}
@Override
public void delete(KafkaConnector resource) {
Expand Down
Expand Up @@ -33,7 +33,7 @@ public KafkaMirrorMaker2 get(String namespace, String name) {
}
@Override
public void create(KafkaMirrorMaker2 resource) {
kafkaMirrorMaker2Client().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
kafkaMirrorMaker2Client().inNamespace(resource.getMetadata().getNamespace()).resource(resource).create();
}
@Override
public void delete(KafkaMirrorMaker2 resource) {
Expand Down
Expand Up @@ -30,7 +30,7 @@ public KafkaMirrorMaker get(String namespace, String name) {
}
@Override
public void create(KafkaMirrorMaker resource) {
kafkaMirrorMakerClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
kafkaMirrorMakerClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).create();
}
@Override
public void delete(KafkaMirrorMaker resource) {
Expand Down
Expand Up @@ -32,7 +32,7 @@ public KafkaRebalance get(String namespace, String name) {
}
@Override
public void create(KafkaRebalance resource) {
kafkaRebalanceClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
kafkaRebalanceClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).create();
}
@Override
public void delete(KafkaRebalance resource) {
Expand Down
Expand Up @@ -51,7 +51,7 @@ public Kafka get(String namespace, String name) {

@Override
public void create(Kafka resource) {
kafkaClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
kafkaClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).create();
}

@Override
Expand Down
Expand Up @@ -31,7 +31,7 @@ public KafkaTopic get(String namespace, String name) {
}
@Override
public void create(KafkaTopic resource) {
kafkaTopicClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
kafkaTopicClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).create();
}
@Override
public void delete(KafkaTopic resource) {
Expand Down
Expand Up @@ -31,7 +31,7 @@ public KafkaUser get(String namespace, String name) {
}
@Override
public void create(KafkaUser resource) {
kafkaUserClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
kafkaUserClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).create();
}

@Override
Expand Down
Expand Up @@ -29,7 +29,7 @@ public StrimziPodSet get(String namespace, String name) {

@Override
public void create(StrimziPodSet resource) {
strimziPodSetClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
strimziPodSetClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).create();
}

@Override
Expand Down
Expand Up @@ -30,7 +30,7 @@ public Deployment get(String namespace, String name) {

@Override
public void create(Deployment resource) {
ResourceManager.kubeClient().createOrReplaceDeployment(resource);
ResourceManager.kubeClient().createDeployment(resource);
}

@Override
Expand Down
Expand Up @@ -22,7 +22,7 @@ public CustomResourceDefinition get(String namespace, String name) {
}
@Override
public void create(CustomResourceDefinition resource) {
kubeClient().createOrReplaceCustomResourceDefinition(resource);
kubeClient().createCustomResourceDefinition(resource);
}
@Override
public void delete(CustomResourceDefinition resource) {
Expand Down
Expand Up @@ -32,7 +32,7 @@ public ClusterRoleBinding get(String namespace, String name) {
}
@Override
public void create(ClusterRoleBinding resource) {
kubeClient(KubeClusterResource.getInstance().defaultNamespace()).createOrReplaceClusterRoleBinding(resource);
kubeClient(KubeClusterResource.getInstance().defaultNamespace()).createClusterRoleBinding(resource);
}
@Override
public void delete(ClusterRoleBinding resource) {
Expand Down
Expand Up @@ -24,7 +24,7 @@ public ClusterRole get(String namespace, String name) {
@Override
public void create(ClusterRole resource) {
// ClusterRole his operation namespace is only 'default'
kubeClient(KubeClusterResource.getInstance().defaultNamespace()).createOrReplaceClusterRoles(resource);
kubeClient(KubeClusterResource.getInstance().defaultNamespace()).createClusterRoles(resource);
}
@Override
public void delete(ClusterRole resource) {
Expand Down
Expand Up @@ -22,7 +22,7 @@ public ConfigMap get(String namespace, String name) {
}
@Override
public void create(ConfigMap resource) {
kubeClient().createOrReplaceConfigMap(resource);
kubeClient().createConfigMap(resource);
}
@Override
public void delete(ConfigMap resource) {
Expand Down
Expand Up @@ -27,7 +27,7 @@ public Deployment get(String namespace, String name) {
}
@Override
public void create(Deployment resource) {
ResourceManager.kubeClient().createOrReplaceDeployment(resource);
ResourceManager.kubeClient().createDeployment(resource);
}
@Override
public void delete(Deployment resource) {
Expand Down
Expand Up @@ -23,7 +23,7 @@ public Lease get(String namespace, String name) {

@Override
public void create(Lease resource) {
kubeClient().getClient().leases().resource(resource).createOrReplace();
kubeClient().getClient().leases().resource(resource).serverSideApply();
}

@Override
Expand Down
Expand Up @@ -28,7 +28,7 @@ public RoleBinding get(String namespace, String name) {
}
@Override
public void create(RoleBinding resource) {
ResourceManager.kubeClient().namespace(resource.getMetadata().getNamespace()).createOrReplaceRoleBinding(resource);
ResourceManager.kubeClient().namespace(resource.getMetadata().getNamespace()).createRoleBinding(resource);
}
@Override
public void delete(RoleBinding resource) {
Expand Down
Expand Up @@ -28,7 +28,7 @@ public Role get(String namespace, String name) {
}
@Override
public void create(Role resource) {
ResourceManager.kubeClient().namespace(resource.getMetadata().getNamespace()).createOrReplaceRole(resource);
ResourceManager.kubeClient().namespace(resource.getMetadata().getNamespace()).createRole(resource);
}
@Override
public void delete(Role resource) {
Expand Down
Expand Up @@ -22,7 +22,7 @@ public ServiceAccount get(String namespace, String name) {
}
@Override
public void create(ServiceAccount resource) {
kubeClient().createOrReplaceServiceAccount(resource);
kubeClient().createServiceAccount(resource);
}
@Override
public void delete(ServiceAccount resource) {
Expand Down
Expand Up @@ -27,7 +27,7 @@ public OperatorGroup get(String namespace, String name) {

@Override
public void create(OperatorGroup resource) {
operatorGroupClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
operatorGroupClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).serverSideApply();
}

@Override
Expand Down
Expand Up @@ -29,7 +29,7 @@ public Subscription get(String namespace, String name) {

@Override
public void create(Subscription resource) {
subscriptionClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).createOrReplace();
subscriptionClient().inNamespace(resource.getMetadata().getNamespace()).resource(resource).serverSideApply();
}

@Override
Expand Down
Expand Up @@ -49,7 +49,7 @@ public Deployment get(String namespace, String name) {
}
@Override
public void create(Deployment resource) {
ResourceManager.kubeClient().createOrReplaceDeployment(resource);
ResourceManager.kubeClient().createDeployment(resource);
}
@Override
public void delete(Deployment resource) {
Expand Down
Expand Up @@ -16,11 +16,11 @@
import io.strimzi.systemtest.Constants;
import io.strimzi.systemtest.Environment;
import io.strimzi.test.TestUtils;
import io.strimzi.test.k8s.KubeClusterResource;

import java.util.Random;

import static io.strimzi.operator.common.Util.hashStub;
import static io.strimzi.test.k8s.KubeClusterResource.kubeClient;

public class KafkaConnectTemplates {

Expand Down Expand Up @@ -56,7 +56,7 @@ public static KafkaConnectBuilder kafkaConnectWithMetricsAndFileSinkPlugin(Strin

private static void createOrReplaceConnectMetrics(String namespaceName) {
ConfigMap metricsCm = TestUtils.configMapFromYaml(Constants.PATH_TO_KAFKA_CONNECT_METRICS_CONFIG, "connect-metrics");
KubeClusterResource.kubeClient().getClient().configMaps().inNamespace(namespaceName).resource(metricsCm).createOrReplace();
kubeClient().createConfigMapInNamespace(namespaceName, metricsCm);
}

private static KafkaConnectBuilder defaultKafkaConnect(KafkaConnect kafkaConnect, final String namespaceName, String name, String kafkaClusterName, int kafkaConnectReplicas) {
Expand Down
Expand Up @@ -18,7 +18,8 @@
import io.strimzi.systemtest.resources.ResourceManager;
import io.strimzi.systemtest.utils.kafkaUtils.KafkaUtils;
import io.strimzi.test.TestUtils;
import io.strimzi.test.k8s.KubeClusterResource;

import static io.strimzi.test.k8s.KubeClusterResource.kubeClient;

public class KafkaMirrorMaker2Templates {

Expand All @@ -32,7 +33,7 @@ public static KafkaMirrorMaker2Builder kafkaMirrorMaker2(String name, String tar
public static KafkaMirrorMaker2Builder kafkaMirrorMaker2WithMetrics(String namespaceName, String name, String targetClusterName, String sourceClusterName, int kafkaMirrorMaker2Replicas, String sourceNs, String targetNs) {
KafkaMirrorMaker2 kafkaMirrorMaker2 = getKafkaMirrorMaker2FromYaml(Constants.PATH_TO_KAFKA_MIRROR_MAKER_2_METRICS_CONFIG);
ConfigMap metricsCm = TestUtils.configMapFromYaml(Constants.PATH_TO_KAFKA_MIRROR_MAKER_2_METRICS_CONFIG, "mirror-maker-2-metrics");
KubeClusterResource.kubeClient().getClient().configMaps().inNamespace(namespaceName).resource(metricsCm).createOrReplace();
kubeClient().createConfigMapInNamespace(namespaceName, metricsCm);
return defaultKafkaMirrorMaker2(kafkaMirrorMaker2, name, targetClusterName, sourceClusterName, kafkaMirrorMaker2Replicas, false, sourceNs, targetNs);
}

Expand Down
Expand Up @@ -84,7 +84,7 @@ public static KafkaBuilder kafkaWithMetrics(String name, String namespace, int k
Kafka kafka = getKafkaFromYaml(Constants.PATH_TO_KAFKA_METRICS_CONFIG);

ConfigMap metricsCm = TestUtils.configMapFromYaml(Constants.PATH_TO_KAFKA_METRICS_CONFIG, "kafka-metrics");
KubeClusterResource.kubeClient().getClient().configMaps().inNamespace(namespace).resource(metricsCm).createOrReplace();
KubeClusterResource.kubeClient().createConfigMapInNamespace(namespace, metricsCm);
return defaultKafka(kafka, name, kafkaReplicas, zookeeperReplicas)
.editOrNewMetadata()
.withNamespace(namespace)
Expand All @@ -103,9 +103,9 @@ public static KafkaBuilder kafkaWithCruiseControl(String name, int kafkaReplicas
public static KafkaBuilder kafkaWithMetricsAndCruiseControlWithMetrics(String namespaceName, String name, int kafkaReplicas, int zookeeperReplicas) {
Kafka kafka = getKafkaFromYaml(Constants.PATH_TO_KAFKA_METRICS_CONFIG);
ConfigMap kafkaMetricsCm = TestUtils.configMapFromYaml(Constants.PATH_TO_KAFKA_METRICS_CONFIG, "kafka-metrics");
KubeClusterResource.kubeClient().getClient().configMaps().inNamespace(namespaceName).resource(kafkaMetricsCm).createOrReplace();
KubeClusterResource.kubeClient().getClient().configMaps().inNamespace(namespaceName).resource(kafkaMetricsCm).serverSideApply();
ConfigMap zkMetricsCm = TestUtils.configMapFromYaml(Constants.PATH_TO_KAFKA_METRICS_CONFIG, "kafka-metrics");
KubeClusterResource.kubeClient().getClient().configMaps().inNamespace(namespaceName).resource(zkMetricsCm).createOrReplace();
KubeClusterResource.kubeClient().getClient().configMaps().inNamespace(namespaceName).resource(zkMetricsCm).serverSideApply();

ConfigMap ccCm = new ConfigMapBuilder()
.withApiVersion("v1")
Expand All @@ -120,7 +120,7 @@ public static KafkaBuilder kafkaWithMetricsAndCruiseControlWithMetrics(String na
" name: kafka_cruisecontrol_$1_$2\n" +
" type: GAUGE"))
.build();
KubeClusterResource.kubeClient().getClient().configMaps().inNamespace(namespaceName).resource(ccCm).createOrReplace();
KubeClusterResource.kubeClient().getClient().configMaps().inNamespace(namespaceName).resource(ccCm).serverSideApply();

ConfigMapKeySelector cmks = new ConfigMapKeySelectorBuilder()
.withName("cruise-control-metrics-test")
Expand Down
Expand Up @@ -1200,9 +1200,9 @@ void testMountingSecretAndConfigMapAsVolumesAndEnvVars(ExtensionContext extensio

kubeClient(namespaceName).createSecret(connectSecret);
kubeClient(namespaceName).createSecret(dotedConnectSecret);
kubeClient(namespaceName).getClient().configMaps().inNamespace(namespaceName).resource(configMap).createOrReplace();
kubeClient(namespaceName).getClient().configMaps().inNamespace(namespaceName).resource(dotedConfigMap).createOrReplace();

kubeClient().createConfigMapInNamespace(namespaceName, configMap);
kubeClient().createConfigMapInNamespace(namespaceName, dotedConfigMap);

resourceManager.createResource(extensionContext, KafkaTemplates.kafkaEphemeral(clusterName, 3).build());
resourceManager.createResource(extensionContext, KafkaConnectTemplates.kafkaConnect(clusterName, namespaceName, 1)
Expand Down
Expand Up @@ -134,7 +134,7 @@ void testConnectWithConnectorUsingConfigAndEnvProvider(ExtensionContext extensio
.endRule()
.build();

kubeClient().getClient().resource(configRole).createOrReplace();
kubeClient().createRole(configRole);

String configPrefix = "configmaps:" + namespaceName + "/connector-config:";

Expand Down