Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated Fabric8 replace() method and replace it with update() #8347

Merged
merged 1 commit into from Apr 6, 2023

Conversation

im-konge
Copy link
Member

@im-konge im-konge commented Apr 5, 2023

Type of change

  • Refactoring

Description

The #8310 is removing deprecated createOrReplace() from the project and this PR takes care of the replace() method, which is also deprecated in the Fabric8 6.5.0.
It replaces the replace() method with update() on a few places in tests.

After these two PRs all deprecated methods should be removed.

Checklist

  • Make sure all tests pass

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge added this to the 0.35.0 milestone Apr 5, 2023
@im-konge im-konge self-assigned this Apr 5, 2023
@im-konge
Copy link
Member Author

im-konge commented Apr 5, 2023

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@im-konge im-konge merged commit 24379f4 into strimzi:main Apr 6, 2023
19 checks passed
@im-konge im-konge deleted the fabric8-replace branch April 6, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants