Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StringIndexOutOfBoundsException on openShiftBuildWaitForFinish #8484

Merged
merged 1 commit into from May 5, 2023

Conversation

fvaleri
Copy link
Contributor

@fvaleri fvaleri commented May 5, 2023

This change fixes #8472.

I think skipping the tag is completely fine (the build works) and latest should be used as default.

Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess we can go with this solution.

@scholzj scholzj added this to the 0.35.0 milestone May 5, 2023
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scholzj
Copy link
Member

scholzj commented May 5, 2023

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Frawless
Copy link
Member

Frawless commented May 5, 2023

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit 0d5bfa4 into strimzi:main May 5, 2023
20 checks passed
@fvaleri fvaleri deleted the fix-connect-build branch May 6, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: CO logs StringIndexOutOfBoundsException when tag is not specified for KafkaConnect build
4 participants