Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ST] RollingUpdateST refactor #9131

Merged
merged 10 commits into from Sep 26, 2023
Merged

[ST] RollingUpdateST refactor #9131

merged 10 commits into from Sep 26, 2023

Conversation

henryZrncik
Copy link
Contributor

@henryZrncik henryZrncik commented Sep 18, 2023 •
edited

Type of change

  • Refactoring

Description

  • testKafkaAndZookeeperScaleUpScaleDown
    • zookeeper related checks removed as they are present in other test in given ST suite.
    • scaling only to 5 replicas instead of 7
    • addition of new topic with replica 4 replicas (more than count of brokers available before Scaling Up from 3 to 5)
    • test renamed accordingly (testKafkaScaleUpScaleDown)
  • testZookeeperScaleUpScaleDown added creation and usage of new KafkaTopic after scale up from 3 to 7 replicas, to verify it can handles new topics.
  • removal of testManualKafkaConfigMapChangeDontTriggerRollingUpdate due to modifying ConfigMap which is rewritten before each Rolling Update
  • testClusterOperatorFinishAllRollingUpdates describing why there is Cluster Operator deleted twice, refactoring waiting for being in the middle of Rolling Update to not use pending state anymore and rather check on snapshot of pre-rolling-update existing Pods.
  • rest of tests are moved with addition of several checks as documented in specific tests Doc.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation

@henryZrncik henryZrncik self-assigned this Sep 18, 2023
@henryZrncik henryZrncik added this to the 0.38.0 milestone Sep 18, 2023
im-konge
im-konge reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few nits, thanks

systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/metrics/MetricsST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/metrics/MetricsST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/metrics/MetricsST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/metrics/MetricsST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/metrics/MetricsST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/rollingupdate/RollingUpdateST.java Outdated Show resolved Hide resolved
see-quick
see-quick approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits. Thanks for your contribution 👍 !!

systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/log/LoggingChangeST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/metrics/MetricsST.java Outdated Show resolved Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/metrics/MetricsST.java Outdated Show resolved Hide resolved
@im-konge
Copy link
Member

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@henryZrncik
testKafkaScaleUpScaleDown removal of zookeeper related checks, additi…
486cad3 
…on of scaled topic

Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik
testZookeeperScaleUpScaleDown addition of new test topic to see zooke…
8a5886d 
…eper can handle it correctly after scaling from 3 to 7 replicas

Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik
testManualKafkaConfigMapChangeDontTriggerRollingUpdate removal due to…
2b06cb9 
… testing modfication of data which are always rewritten (before rolling update)

Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik
move testClusterOperatorFinishAllRollingUpdates to LoggingChangeST
4a3f9c0 
Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik
testClusterOperatorFinishAllRollingUpdates removal of pending check i…
881a7b5 
…n the middle of Rolling update, added description of steps

Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik
move testMetricsChange to MetricST and add check that enabling metri…
989551c 
…c triggers rolling update

Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik
rolling update tests added simple documentation
20e5907 
Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik
rolling update st fix selectors intend and logging
bf7bbe8 
Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik
kafka scale up scale down update replica count to reflect possible to…
040a0c6 
…pic deletion error

Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik henryZrncik force-pushed the triage-2023-04-18-rolling-update-st branch from cc6c30a to 040a0c6 Compare September 25, 2023 11:08
@im-konge
Copy link
Member

/azp run regression

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@henryZrncik
RollingUpdateST scaleupanddownkafka remove deletion of kafka topic wi…
3d9df48 
…th multiple replicas

Signed-off-by: hzrncik <hzrncik@redhat.com>
@see-quick see-quick added the ready for merge Label for PRs which are ready for merge label Sep 26, 2023
@see-quick see-quick merged commit 2f28750 into strimzi:main Sep 26, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@see-quick see-quick see-quick approved these changes

@im-konge im-konge im-konge approved these changes

Assignees

@henryZrncik henryZrncik

Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Milestone
0.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@henryZrncik @im-konge @see-quick