Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ST] KafkaRoller prevent scale down if partition present #9305

Merged
merged 2 commits into from Nov 7, 2023
Merged

[ST] KafkaRoller prevent scale down if partition present #9305

merged 2 commits into from Nov 7, 2023

Conversation

henryZrncik
Copy link
Contributor

Type of change

  • Enhancement / new feature
  • Refactoring

Description

  • test testKafkaRollsWhenTopicIsUnderReplicated renamed to testKafkaDoesNotRollsWhenTopicIsUnderReplicated in regard to new feature which prevent scale down
  • refactor mainly to usage of testStorage instead of several variables and removal of unnecessary steps.
  • topic is created and removed instead of adding partitions scaling up and down and using rebalances as this would need several other steps diverting from purpose of test.
  • additionaly one extra check is used while waiting for condition messsage to prevent extra Error logs bearing no information

fixes #9134

Checklist

  • Write tests
  • Make sure all tests pass

@henryZrncik
[ST] KafkaRoller prevent scale down if partition present
22c7566 
Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik henryZrncik self-assigned this Oct 30, 2023
@henryZrncik henryZrncik added this to the 0.39.0 milestone Oct 30, 2023
@henryZrncik
more specific logs
f3c00cc 
Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik
Copy link
Contributor Author

@strimzi-ci run tests --testcase=KafkaRollerST

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS:
TEST_CASE: KafkaRollerST
TOTAL: 5
PASS: 5
FAIL: 0
SKIP: 0
BUILD_NUMBER: 284
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

@ShubhamRwt ShubhamRwt self-requested a review November 2, 2023 08:35
@im-konge
Copy link
Member

im-konge commented Nov 6, 2023

/azp run regression

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@henryZrncik henryZrncik added the ready for merge Label for PRs which are ready for merge label Nov 7, 2023
@henryZrncik
Copy link
Contributor Author

Azure Pipelines successfully started running 1 pipeline(s).

Ready for merge: failed test are due to known issue outside of scope of this PR.

@im-konge im-konge merged commit 49bcef1 into strimzi:main Nov 7, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@see-quick see-quick see-quick approved these changes

@ShubhamRwt ShubhamRwt ShubhamRwt approved these changes

@im-konge im-konge im-konge approved these changes

Assignees

@henryZrncik henryZrncik

Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Milestone
0.39.0
5 participants
@henryZrncik @strimzi-ci @im-konge @see-quick @ShubhamRwt