Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] ConnectorsST and MirrorMaker2ST add checks for newly added connector.spec.state #9415

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

henryZrncik
Copy link
Contributor

@henryZrncik henryZrncik commented Nov 30, 2023

Type of change

  • Enhancement
  • Refactor

Description

add documentation, refactor and use helper method in newly renamed test testKafkaConnectAndConnectorStateWithFileSinkPlugin

add checks for KafkaConnector spec.state usage of stopping, pausing and running given KafkaConnector.

add stopping and resuming source connector in of tests in MirrorMaker2ST.

Checklist

  • Write tests
  • Make sure all tests pass

@henryZrncik henryZrncik self-assigned this Nov 30, 2023
@henryZrncik henryZrncik added this to the 0.39.0 milestone Nov 30, 2023
@henryZrncik henryZrncik marked this pull request as draft November 30, 2023 21:59
@henryZrncik
Copy link
Contributor Author

converted to draft as will be adding new checks for MM2 connectors as well.

…unning

Signed-off-by: hzrncik <hzrncik@redhat.com>
…in to use helper method

Signed-off-by: hzrncik <hzrncik@redhat.com>
Signed-off-by: hzrncik <hzrncik@redhat.com>
Signed-off-by: hzrncik <hzrncik@redhat.com>
@henryZrncik henryZrncik changed the title [ST] ConnectorsST add checks for newly added connector.spec.state [ST] ConnectorsST and MirrorMaker2ST add checks for newly added connector.spec.state Dec 8, 2023
@henryZrncik henryZrncik marked this pull request as ready for review December 8, 2023 14:28
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@im-konge
Copy link
Member

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick see-quick merged commit 320b5e2 into strimzi:main Dec 12, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants