[ST] KRaft to KRaft upgrades/downgrades in STs #9442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see-quick
reviewed
Dec 6, 2023
systemtest/src/main/java/io/strimzi/systemtest/resources/crd/KafkaNodePoolResource.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/AbstractKRaftUpgradeST.java
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftStrimziDowngradeST.java
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftKafkaUpgradeDowngradeST.java
Show resolved
Hide resolved
im-konge
force-pushed
the
kraft-to-kraft-st
branch
from
7a10e2d
to
6e4da64
Compare
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
reviewed
Dec 7, 2023
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftKafkaUpgradeDowngradeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftKafkaUpgradeDowngradeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftKafkaUpgradeDowngradeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftKafkaUpgradeDowngradeST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/upgrade/kraft/KRaftKafkaUpgradeDowngradeST.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
/azp run upgrade |
|
Azure Pipelines successfully started running 1 pipeline(s). |
scholzj
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR adds STs for KRaft to KRaft upgrades/downgrades.
I decided to make a copy of our current tests that we have in our suite and create new package
kraftfor the KRaft to KRaft STs. As part of that, I moved the "regular" tests into theregularpackage.As for the regular tests, for KRaft upgrades/downgrades I'm using the
AbstractKRaftUpgradeSTclass, which extends theAbstractUpgradeST. To keep the methods same as much as possible, I moved some parts to separate methods, which are then overriden in theAbstractKRaftUpgradeST. So even if we are executing some method in theAbstractUpgradeST, if there is some method in theAbstractKRaftUpgradeSTthat overrides it, the test uses that one.KRaftKafkaUpgradeDowngradeSTworks as expected, it does testing of just Kafka upgrade/downgrade. The two classes that are testing the Strimzi & Kafka upgrades/downgrades are implemented as well, theKRaftStrimziUpgradeSTworks, but theKRaftStrimziDowngradeSTis currently disabled, as0.38.0version of Strimzi doesn't support KRaft to KRaft upgrades/downgrades, so that scenario will not currently work. But after0.39.0is released, it should be enabled -> and from my testing the tests inside the downgrade suite should work.As part of this PR I'm changing few classes regarding Kafka version (adding the
metadataVersion), loaders for the upgrade/downgrade tests (possibility to specify "always enabled" FG -> used for KRaft, UTO, and KafkaNodePools FGs),and also adding some helper methods for the NodePools creation to the templates or LabelSelector for getting Pods for particular NodePool.
Finally, I'm adding these STs to AZP and updating our
pom.xmlwithkraft_upgradeprofile + addingKRaftKafkaUpgradeDowngradeSTtoazp_kafka_upgradeprofile.Checklist