Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullPointerException From Missing listenerConfig #9489

Merged
merged 2 commits into from Dec 27, 2023

Conversation

MarkintoshZ
Copy link
Contributor

Type of change

  • Bugfix

Description

Fix for #9398.

An empty hashmap is instantiated and used if listenerConfig is not supplied when using custom auth.

I could not run written test cases due to issue #8526 but I was able to test this locally and verified that the issue is resolved.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Signed-off-by: Mark Zhang <bf-109g2@hotmail.com>
Signed-off-by: Mark Zhang <bf-109g2@hotmail.com>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@scholzj scholzj added this to the 0.40.0 milestone Dec 27, 2023
@scholzj
Copy link
Member

scholzj commented Dec 27, 2023

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@scholzj scholzj merged commit a6654ce into strimzi:main Dec 27, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Optional Kafka Authentication Properties Cause Repeated NullPointerException in Cluster Operator
3 participants