ISSUE-9231 Makes Kafka Exporter offset.show-all configurable #9494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ilkerkocatepe <kocatepeilker@gmail.com>
ilkerkocatepe
force-pushed
the
ISSUE-9231
branch
from
9f31fde
to
932dd01
Compare
Signed-off-by: ilkerkocatepe <kocatepeilker@gmail.com>
Signed-off-by: ilkerkocatepe <kocatepeilker@gmail.com>
Signed-off-by: ilkerkocatepe <kocatepeilker@gmail.com>
scholzj
reviewed
Jan 1, 2024
There was a problem hiding this comment.
Thanks for the PR. I left some minor comments, but I think it looks good. What you have to do to get the build pass is to build it locally to generate the new CRDs and documentation. For example something like MVN_ARGS=-DskipTests make all and commit them with the PR (more details on the building of Strimzi, the tools you need to have installed etc. should be here: https://github.com/strimzi/strimzi-kafka-operator/blob/main/development-docs/DEV_GUIDE.md).
docker-images/kafka-based/kafka/exporter-scripts/kafka_exporter_run.sh
Outdated
Show resolved
Hide resolved
api/src/main/java/io/strimzi/api/kafka/model/KafkaExporterSpec.java
Outdated
Show resolved
Hide resolved
Signed-off-by: ilkerkocatepe <kocatepeilker@gmail.com>
Signed-off-by: ilkerkocatepe <kocatepeilker@gmail.com>
Signed-off-by: ilkerkocatepe <kocatepeilker@gmail.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
reviewed
Jan 2, 2024
api/src/main/java/io/strimzi/api/kafka/model/KafkaExporterSpec.java
Outdated
Show resolved
Hide resolved
ppatierno
approved these changes
Jan 2, 2024
Signed-off-by: ilkerkocatepe kocatepeilker@gmail.com <kocatepeilker@gmail.com>
|
@ilkerkocatepe You will need to rebuild the project again to get the updated description to the CRDs and documentation. |
Signed-off-by: ilkerkocatepe kocatepeilker@gmail.com <kocatepeilker@gmail.com>
|
Thanks for the PR @ilkerkocatepe |
|
Thanks for your help @scholzj @ppatierno |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Allow to configure Kafka Exporter
offset.show-all#9231Checklist