Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST] Fix detecting kind in systemtests #9504

Merged
merged 1 commit into from Jan 7, 2024

Conversation

jankalinic
Copy link
Contributor

Type of change

  • Refactoring

Description

This PR is just a small fix to correctly detect the kind cluster type only when kind cluster is present and then act accordingly when running STs. This change should avoid selecting kind during STs run - when no kind cluster was available and tester was on different cluster type.

Checklist

  • Make sure all tests pass
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

Signed-off-by: jkalinic <jkalinic@redhat.com>
@jankalinic jankalinic added this to the 0.40.0 milestone Jan 5, 2024
@jankalinic jankalinic self-assigned this Jan 5, 2024
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jankalinic jankalinic added ready for merge Label for PRs which are ready for merge and removed ready for merge Label for PRs which are ready for merge labels Jan 5, 2024
@jankalinic
Copy link
Contributor Author

@strimzi-ci run tests --cluster-type=ocp --cluster-version=4.14 --profile=all --testcase=ConnectST

@strimzi-ci
Copy link

▶️ Build started - check Jenkins for more info. ▶️

@strimzi-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: all
GROUPS:
TEST_CASE: ConnectST
TOTAL: 16
PASS: 16
FAIL: 0
SKIP: 0
BUILD_NUMBER: 308
OCP_VERSION: 4.14
BUILD_IMAGES: false
FIPS_ENABLED: false
PARALLEL_COUNT: 5
EXCLUDED_GROUPS: loadbalancer,nodeport,olm

@jankalinic jankalinic added the ready for merge Label for PRs which are ready for merge label Jan 6, 2024
@scholzj scholzj merged commit ff8408d into strimzi:main Jan 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants