Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename *Resources.*StatefulSetName and deploymentName methods #9520

Merged
merged 4 commits into from Jan 9, 2024

Conversation

Anefu
Copy link
Contributor

@Anefu Anefu commented Jan 8, 2024

Type of change

  • Refactoring

Description

PR renames the *StatefulSetName methods to *ComponentName and deploymentName to componentName. Closes #9406.

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you please rebase it? As we just merged a PR that caused some conflicts. Thanks.

@scholzj scholzj requested a review from ppatierno January 8, 2024 10:46
@scholzj scholzj added this to the 0.40.0 milestone Jan 8, 2024
Signed-off-by: Anefu <einsteinanefu@gmail.com>
@scholzj
Copy link
Member

scholzj commented Jan 8, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj requested a review from im-konge January 8, 2024 17:25
Signed-off-by: Anefu <einsteinanefu@gmail.com>
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the tests side.
Thanks for the PR :) good job

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@scholzj scholzj merged commit bbda1f7 into strimzi:main Jan 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide how to deal with the old methods in the api module *Resources classes
4 participants